From 710b86f0a8e209c0349a71223ec329953c16fbb0 Mon Sep 17 00:00:00 2001 From: Sam Reed Date: Fri, 13 Aug 2010 11:29:13 +0000 Subject: [PATCH] Fix archiveName to archiveNames (wrong declaration) Fix unused variable Return params instead of saving in ApiTest --- includes/RevisionDelete.php | 2 +- includes/specials/SpecialSearch.php | 1 - maintenance/tests/ApiTest.php | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/RevisionDelete.php b/includes/RevisionDelete.php index 2940b9f0e9..347607220e 100644 --- a/includes/RevisionDelete.php +++ b/includes/RevisionDelete.php @@ -1009,7 +1009,7 @@ class RevDel_FileList extends RevDel_List { var $storeBatch, $deleteBatch, $cleanupBatch; public function doQuery( $db ) { - $archiveName = array(); + $archiveNames = array(); foreach( $this->ids as $timestamp ) { $archiveNames[] = $timestamp . '!' . $this->title->getDBkey(); } diff --git a/includes/specials/SpecialSearch.php b/includes/specials/SpecialSearch.php index 2dba5977aa..12a70f9238 100644 --- a/includes/specials/SpecialSearch.php +++ b/includes/specials/SpecialSearch.php @@ -961,7 +961,6 @@ class SpecialSearch { protected function shortDialog( $term ) { $searchTitle = SpecialPage::getTitleFor( 'Search' ); - $searchable = SearchEngine::searchableNamespaces(); $out = Html::hidden( 'title', $searchTitle->getPrefixedText() ) . "\n"; // Keep redirect setting $out .= Html::hidden( "redirs", (int)$this->searchRedirects ) . "\n"; diff --git a/maintenance/tests/ApiTest.php b/maintenance/tests/ApiTest.php index d8fc49d08a..95afb01858 100644 --- a/maintenance/tests/ApiTest.php +++ b/maintenance/tests/ApiTest.php @@ -7,7 +7,7 @@ class MockApi extends ApiBase { public function __construct() { } public function getAllowedParams() { - $params = array( + return array( 'filename' => null, 'enablechunks' => false, 'sessionkey' => null, -- 2.20.1